Address Pr Feedback

Address PR Feedback

Turns a PR's review activity — and its CI/status checks — into fixes plus a clean, fully-resolved thread list and a green check bar. The core pattern is fetch → categorize → address → reply & resolve → verify, using scripts for the mechanical parts so the interesting work is reading feedback correctly and knowing when a decision belongs to a human instead of you.

| Script | Purpose | |--------|---------| | scripts/fetch-feedback.sh | Fetch review threads (paginated), discussion comments, and reviews in one JSON payload | | scripts/fetch-checks.sh | Fetch status checks (GitHub Actions + third-party) and failed-step logs for any failing Actions run | | scripts/resolve-thread.sh | Reply to (optional) and resolve one review thread by GraphQL node ID | | scripts/resolve-threads.sh | Batch version: reads [{"thread_id": "...", "comment": "..."}, ...] from stdin | | scripts/reply-comment.sh | Post a top-level PR comment — for discussion-comment replies or a final summary |

See [references/graphql-reference.md](references/graphql-reference.md) for the underlying queries/mutations, why plain first: N GraphQL calls silently truncate on long-running PRs, and why replying and resolving are separate mutations. See [references/checks-reference.md](references/checks-reference.md) for how the Checks API and third-party status checks differ, and how to re-run or diagnose each.

Recognizing the request

The trigger is almost always a short imperative naming a PR, sometimes bundled with other git operations:

• "Address the PR feedback [on #N / \]"
• "For any comment that is addressed, mark it as resolved"
• "Address PR feedback, resolving comments that have been handled"
• "Rebase, resolve the conflicts, and then address the PR feedback"
• "Address feedback across the set of open PRs" / "walk through the PR chain,

addressing feedback on the PRs first, then merge" (a stacked-PR batch)

• "Review the latest human-contributed feedback" / "there's more bot feedback

to evaluate" (a re-check after previously addressing a first round)

• "Fix the failing checks [on #N]" / "the CI is red, why?" / "address the

GitGuardian alert" / "pre-commit.ci is failing" — a checks-only request, not review-comment feedback; jump straight to [Phase 1b — Checks](#phase-1b--checks) below

• "Address the PR feedback" alone, with no mention of checks, still means

glance at the check bar (Phase 1b) — a PR with unresolved review comments and a failing required check is not addressed until both are handled

Resolve two things before running anything, asking if either is unclear:

1. Which PR(s)? A URL or #N in the message is unambiguous — use it.

When none is given, use this session as context before asking: if you opened or pushed to a PR earlier in this same conversation, that's almost always the one meant (dogfooding a skill you just built, continuing work you just pushed) — don't re-ask for something you already know. Otherwise fall back to gh pr view --json url,number for the current branch's tracked PR, and only ask the user if that's still ambiguous (no tracked PR, or reason to think the branch points at the wrong one). A request spanning multiple PRs (a stack, or "all my open PRs") means working through each one, one at a time — don't parallelize commits across PRs that depend on each other.

1. Report or act? This skill is almost always invoked to act (fix code,

reply, resolve) — that's what "address" means here, unlike [github-pr-triage](../github-pr-triage/SKILL.md) which defaults to report-only. If the user says "review the feedback" or "give me a summary" without "address"/"fix"/"resolve", treat it as read-only: categorize and report, but don't change code or touch thread state.

Phase 1 — Fetch

./skills/process/address-pr-feedback/scripts/fetch-feedback.sh mitodl/agent-kit 116 /tmp/pr116-feedback.json

This is one call regardless of PR size — it follows GraphQL cursor pagination for review threads internally, so a PR with 200 threads across a dozen review rounds comes back complete, not truncated at the first page. By default it excludes already-resolved threads; add --include-resolved when you need the full history (e.g. re-checking a PR you partially addressed in an earlier session, or producing a final "here's everything, resolved and not" summary).

Output shape: {repo, pr, review_threads: [...], discussion_comments: [...], reviews: [...]}. Each review_threads[] entry carries the GraphQL id (pass this straight to resolve-thread.sh), isResolved, isOutdated, path/line, and its comments. Every comment, discussion comment, and review also carries author_type alongside author — GitHub's own actor type (User, Bot, Organization, Mannequin), normalized from GraphQL's __typename and REST's user.type so it reads the same regardless of which call produced the record. Classify authorship from that field, not from whether you recognize the login.

Phase 1b — Checks

./skills/process/address-pr-feedback/scripts/fetch-checks.sh mitodl/agent-kit 116 /tmp/pr116-checks.json

Covers both GitHub Actions jobs and third-party status checks (pre-commit.ci, GitGuardian, Sentry, CodeQL, and anything else posting to the PR's check bar) in one call. Excludes passing/skipped checks by default; add --include-passing for the full bar (e.g. a final "everything green" report).

Output shape: {repo, pr, checks: [...], action_run_logs: {: }}. Each checks[] entry has name, bucket (pass/fail/pending/skipping/cancel), state, description, workflow, link, and a derived run_id when the check is a GitHub Actions job. For every failing check with a run_id, action_run_logs holds that run's failed-step output (deduped — several failing jobs from the same workflow run share one log entry), truncated to the last ~20k characters, so you can usually diagnose without a separate gh run view call. Checks with run_id: null (pre-commit.ci, GitGuardian, Sentry, a legacy commit-status check, etc.) have no fetchable log here — their link points at the external service; fetch it directly if it's a public page, otherwise summarize from description and ask the user if more detail is needed — rather than guessing at the failure from the name alone.

A pending check isn't a failure — don't "fix" something that's still running. If everything is pass/pending and the user asked to address checks specifically, say so and stop; there's nothing to act on yet beyond noting what's still in flight.

Phase 2 — Categorize

Group by reviewer and tag each item with a priority, inheriting the reviewer's own label when it supplies one (bot reviewers like gemini-code-assist and copilot-pull-request-reviewer usually embed a severity in the comment body or as a badge) — otherwise infer from substance:

1. **gemini-code-assist** (medium): transport type mismatch in agent-config.toml
2. **copilot-pull-request-reviewer** (nitpick): variable naming in fetch loop
3. **human — tmacey** (substantive): reconsider the retry backoff strategy

isOutdated: true does not mean "safe to skip" — the line moved but the underlying concern may still apply. Read the current code at that path before deciding a stale-looking thread is moot.

Bot review-state fields (APPROVED/COMMENTED/CHANGES_REQUESTED in reviews[]) tell you formality, not substance — most bots (Copilot, Gemini) leave everything in COMMENTED state with the real content in the thread comments, same as noted in [github-pr-triage](../github-pr-triage/SKILL.md#phase-3--classify).

A human reviewer's comment gets more deliberate handling than a bot's, even when the fix looks equally obvious. A bot flags a pattern; a human colleague is making a judgment call, and a quick autonomous fix-and-resolve can read as brushing off their input. For human-authored threads: don't auto-resolve on your own judgment alone — bring the proposed fix (or your reasoning for declining) to the operator before pushing and resolving, and use their framing in the reply rather than your paraphrase. Bot-authored threads (Copilot, Gemini, CodeQL, etc.) don't need that same checkpoint — address, reply, and resolve those directly per the rest of this skill.

Decide which branch applies from author_type (Phase 1's output), never from whether the login looks like a bot — an unfamiliar GitHub App or a newly-added reviewer has no recognizable name, and guessing wrong applies the wrong handling to a colleague. Bot (and Mannequin, an imported placeholder identity) take the bot branch; Organization is rare on review threads and takes the human branch.

User is the one value that doesn't settle it: a service account driving automation through a normal user token reports User exactly like a person does, because GitHub has no field that distinguishes them. When a User thread reads like machine output — templated phrasing, a severity badge, an identical comment repeated across files — say that's your read and ask, rather than silently taking the bot branch on a thread a colleague wrote.

Failing checks split into three kinds that get handled differently in Phase 3 — tag each one on the way in:

1. Your own CI (unit/integration tests, lint, build, typecheck — usually

workflow is a repo-owned workflow name). A code problem to fix like any other actionable item: read action_run_logs[] for the actual failure, fix it, push, and the check re-runs on its own.

1. Auto-fixable formatting/lint bots (pre-commit.ci is the common case).

These often can't be fixed by editing and pushing yourself — pre-commit.ci in particular reacts to a PR comment (pre-commit.ci autofix) or you can run the same hooks locally and push the diff. Check the failure's link for the specific instruction before guessing.

1. Security/compliance scanners (GitGuardian, CodeQL alerts, Sentry-linked

checks, secret scanning). Never treat these like an ordinary lint failure — see the "Security/compliance-flagged findings" rule in [When to stop and ask instead of deciding](#when-to-stop-and-ask-instead-of-deciding). This applies even when the check is the only thing blocking merge and the fix looks obvious (e.g. "just delete the leaked-looking string") — deleting a secret from the current diff does not remove it from git history, and rotation is a decision with consequences beyond this PR.

Phase 3 — Address

For each actionable item: make the code change, run the relevant tests/lint/build for that change before moving to the next one. Commit with a message that names what was addressed, not just "address PR feedback".

When the item is a genuine bug (not a style/naming nit), prefer proving the fix over asserting it: extend or add a test that fails against the unfixed code, confirm the failure, then apply the fix and confirm it passes. This before/after result is worth citing in the reply or PR summary — it's stronger evidence than "fixed" on its own, and it's cheap when the bug is already localized by the reviewer's comment.

Disagreeing with a reviewer is a legitimate outcome — but it must be verified, not assumed. Before skipping a suggestion because it "looks unnecessary": read the actual code path the reviewer is pointing at and confirm your reasoning holds (e.g. a suggested defensive check is redundant only if you've confirmed the caller genuinely always guarantees the precondition — check every call site, not just the obvious one). Once verified, say so explicitly in the reply (with the evidence) — never resolve a thread by silently ignoring it, and never reply with a content-free "noted" or "will consider". A good decline reads like: "Verified — write_bindings always calls ensure_bridge_store first at every call site, so this fallback path is unreachable. Not adding it; would reintroduce the redundant read this PR removes."

The same verify-before-asserting rule applies to any claim about runtime or production behavior, not just code-path reasoning — "prod never showed this", "this is why the metric moved", "the library defaults to X". Code reading alone doesn't verify those; check the live source instead (Prometheus/Grafana, the actual library source/docs rather than memory, or the infra definition as deployed rather than as written). Size the query window to the claim: an assertion about a period — "prod never showed this", "this has been broken since the July deploy" — is only supported by a window covering that whole period, and if retention won't reach that far back, the claim gets narrowed to what you actually queried ("no occurrences in the last 30 days") rather than asserted whole. Seven days is the floor for trend claims, where the window exists to keep a short blip from reading as a trend — it is a minimum, not a sufficient window for an absence claim. A claim you can't verify before replying gets flagged as unverified or left out — it doesn't ship as fact and get walked back after a reviewer catches it.

For a failing check, read action_run_logs[] (from Phase 1b) before touching code — a stack trace or assertion diff tells you exactly what broke, where a guess from the check name alone often doesn't. If a test looks flaky rather than broken by this PR's changes (same test fails intermittently across unrelated commits, or the log shows a timeout/network blip unrelated to the diff), say that's your read and re-run rather than "fixing" a non-issue:

gh run rerun  -R mitodl/agent-kit --failed

Don't reach for --failed reruns as a first response to every red check, though — re-running without understanding the failure just burns CI minutes and may mask a real, intermittently-reproducing bug. Only use it once you've read the log and concluded the failure is genuinely unrelated to this PR's changes.

Phase 4 — Reply & resolve

Reply style: one or two sentences. Name the commit and what changed, or the evidence and the conclusion. Nothing else — no thanks-for-the-review opener, no restating the reviewer's comment back at them, no closing offer to discuss further, no emoji. A reviewer reading twelve replies wants twelve facts.

Fixed in a1b2c3d: transport is now streamable-http.
Verified — ensure_bridge_store runs at every call site, so this path is
unreachable. Not adding the guard.

Where the reply carries a judgment the user made (a decline they decided on, a disagreement with a reviewer, a deferral), post their framing rather than your own paraphrase — ask for the wording if you don't already have it. Those replies are read as the author's position, not the tool's.

For each thread you touched, reply with what changed (cite the commit) and resolve in one call:

./skills/process/address-pr-feedback/scripts/resolve-thread.sh \
  --thread-id PRRT_kwDORsi4Ac6PsuPQ \
  --comment "Fixed in a1b2c3d: switched transport to streamable-http per the schema."

For a batch, build the JSON and pipe it once:

jq -n '[
  {thread_id: "PRRT_...", comment: "Fixed in a1b2c3d: ..."},
  {thread_id: "PRRT_...", comment: "Verified — false positive, see reply. No change needed."}
]' | ./skills/process/address-pr-feedback/scripts/resolve-threads.sh

Checks have no resolution state either — like discussion comments, there's no thread to mark resolved. A code fix and push is the resolution; the check re-runs and flips green on its own. For a scanner finding you investigated and declined to act on (Phase 3's security/compliance rule — only after the user has weighed in), record the reasoning in the same PR summary comment rather than a per-check reply, since most check UIs don't support one.

Top-level discussion comments have no resolution state — reply to those (or post one consolidated summary of the whole pass) with `reply-comment

…

Source & license

This open-source skill is cataloged on AgentStack and links to its original source — we do not rehost the code.

• Author: mitodl
• Source: mitodl/agent-kit
• License: BSD-3-Clause

Install and usage instructions live in the source repository linked above.