Code Review And Quality

Code Review and Quality

When to use

Use this skill when reviewing a diff written by yourself, another agent or a human, or when deciding whether a change is ready to merge.

Objective

Identify correctness risks, test gaps, maintainability problems, hidden regressions and security concerns before the change lands.

Procedure

1. Read the change in the context of the surrounding code.
2. Identify the intended behaviour and any behaviour change.
3. Check correctness, edge cases, tests and public contracts.
4. Assess maintainability, duplication and naming only after correctness is clear.
5. Classify findings by severity and impact.
6. Suggest the smallest fix or follow-up needed to close each finding.

Rules

• Do not review in isolation from the code the diff touches.
• Do not let style preferences outrank correctness or safety.
• Do not suppress a real issue just because the diff is small.
• Do not approve a change without checking the relevant tests or evidence.

Related skills

• tdd-practice — tests as review evidence
• logical-fallacy-review — invalid reasoning in review comments
• git-workflow-and-versioning — reviewable atomic changes
• guardrails-safety-patterns — security findings in review

References

• Google Engineering Practices — Code Review Developer Guide

Verification

• [ ] Findings listed with severity and evidence.
• [ ] Tests or checks run reported.
• [ ] Correctness assessed before style concerns.
• [ ] Residual risks requiring follow-up stated.

Source & license

This open-source skill is cataloged on AgentStack and links to its original source — we do not rehost the code.

• Author: mmccalla
• Source: mmccalla/coding-agent-skill-library
• License: Apache-2.0

Install and usage instructions live in the source repository linked above.